-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key binds to Jump for cycling through tabs and sites. #123
base: main
Are you sure you want to change the base?
Conversation
Nice, thanks! Great idea I'll give it a whirl over the next few days, just had a quick look at the code on my phone and it looks good. |
I just noticed I failed to test properly and found some small issues. A fix is on its way, though :-). The next commit will hopefully be solid. |
Awesome, no worries. Thanks again 😁 |
I committed the fixes. Thanks for taking an interest in the change! |
Thanks for taking an interest in Jump! 🙂 |
After careful consideration I added a final commit. When switching tags with the keys, it makes sense to start cycling from the active tag instead of always from the first one. I used it myself for a bit and like how it works. If you however dislike this approach, feel free to remove commit |
I forgot about the optional search box. With the last commit, the key binds play nice with it enabled. The escape key now also closes the search box. |
This PR adds key binds to Jump:
T
will open or close the tags menu.↑
,↓
,←
or→
will cycle through the tags when the tags menu is open.↑
and←
will both cycle back, whereas↓
and→
will cycle forward.Enter
will activate the selected tag or site.Escape
will clear selections.Ctrl
followed by a number will open the site at that position. For example,Ctrl
+1
will open the site on the first tile,Ctrl
+2
the site on the second tile, and so on. The first ten tiles can be opened this way.